Tests in 'load' and 'loadapi'

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Tests in 'load' and 'loadapi'

Eli Zaretskii
Paul,

Were these two tests run successfully on Unix?  I needed the following
patch to get them to run on MS-Windows, otherwise the test suite
insisted that 'load' is not in .FEATURES, although it definitely is:

--- scripts/features/load~0 2020-01-03 09:11:27.000000000 +0200
+++ scripts/features/load 2020-01-26 10:45:53.927718000 +0200
@@ -4,7 +4,9 @@ $description = "Test the load operator."
 $details = "Test dynamic loading of modules.";
 
 # Don't do anything if this system doesn't support "load"
-exists $FEATURES{load} or return -1;
+if (!exists($FEATURES{load})) {
+    return -1;
+}


I don't speak Perl, so maybe I'm missing something silly here.

Also, the fact that the "load" command requires a full file name,
including the extension, gets in the way of portable Makefiles,
because you need foo.so on Unix, foo.dll on Windows, and foo.dynlib on
macOS.  WIBNI you could say "load foo(bar)" and have Make try foo.EXT
if foo didn't exist (wehere .EXT is the platform-specific extension)?