[bug #57778] Stop looking for an included file once found, even if cannot be opened.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[bug #57778] Stop looking for an included file once found, even if cannot be opened.

Yann E. MORIN
URL:
  <https://savannah.gnu.org/bugs/?57778>

                 Summary: Stop looking for an included file once found, even
if cannot be opened.
                 Project: make
            Submitted by: dgoncharov
            Submitted on: Sun 09 Feb 2020 05:07:07 PM UTC
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
       Component Version: None
        Operating System: None
           Fixed Release: None
           Triage Status: None

    _______________________________________________________

Details:

Good morning.                                                                
                                                                             
                     
                                                                             
                                                                             
                     
Stop looking for an included file once found, even if cannot be opened.      
                                                                             
                     
                                                                             
                                                                             
                     
If the current directory contains a not readable file and an additional
include directory contains a readable file the current file is silently
ignored and the file from the additional include directory is silently
included.
This can come as an unpleasant surprise and is hardly useful.
This behavior contradicts gnu make manual and usual practice in similar
situations.

Gnu make manual explicitly states that lookup continues only if the file is
missing.
Gnu make itself stops looking for a prerequisite file in vpath directories,
once it found one, even if cannot be opened.
Gnu make stops looking for an included file once it found one and the found
one turns out to be corrupt or a directory.
Similarly a compiler stops looking for a header once it found one, even if
cannot be opened.


The change from rmfiles to unlink in features/included is needed to have the
test pass when -keep is specified.

regards, Dmitry




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 09 Feb 2020 05:07:07 PM UTC  Name: stop_lookup_for_included.diff
Size: 5KiB   By: dgoncharov

<http://savannah.gnu.org/bugs/download.php?file_id=48386>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57778>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/