patch, test suite fails to run valgrind

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

patch, test suite fails to run valgrind

Gnu - Make - Bugs mailing list
Good morning.

The test suite fails to run valgrind with an error message like the following.


$ ./run_make_tests -memcheck -make_path ../l64/make

features/archives ....................................... ok     (12 passed)
features/comments .......................................
*** Test died (features/comments): Command failed: exec: Cannot execute valgrind --log-fd=4 --num-callers=15 --tool=memcheck --leak-check=full --suppressions=guile.supp /home/dgoncharov/src/gmake/make/tests/../l64/make

This happens because _run_with_timeout attempts to exec an array, while exec expects a list.

regards, Dmitry

diff --git a/tests/test_driver.pl b/tests/test_driver.pl
index 1bb98ba..511a43f 100644
--- a/tests/test_driver.pl
+++ b/tests/test_driver.pl
@@ -1008,7 +1008,7 @@ sub _run_with_timeout
   } else {
     my $pid = fork();
     if (! $pid) {
-      exec(@_) or die "exec: Cannot execute $_[0]\n";
+      exec("@_") or die "exec: Cannot execute $_[0]: $!\n";
     }
     local $SIG{ALRM} = sub {
       my $e = $ERRSTACK[0];


_______________________________________________
Bug-make mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-make
Reply | Threaded
Open this post in threaded view
|

Re: patch, test suite fails to run valgrind

Paul Smith-20
On Wed, 2019-09-18 at 21:38 -0400, Dmitry Goncharov via Bug reports and
discussion for GNU make wrote:
> The test suite fails to run valgrind with an error message like the following.

I pushed a different fix for this issue.  Thanks for noticing!


_______________________________________________
Bug-make mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-make
Reply | Threaded
Open this post in threaded view
|

Re: patch, test suite fails to run valgrind

Gnu - Make - Bugs mailing list
On Sat, Sep 21, 2019 at 04:54:59PM -0400, Paul Smith wrote:
> I pushed a different fix for this issue.  Thanks for noticing!
Thank you.
Do you intentionally avoid $! in the "Cannot execute" error message?
regards, Dmitry


>

_______________________________________________
Bug-make mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-make
Reply | Threaded
Open this post in threaded view
|

Re: patch, test suite fails to run valgrind

Paul Smith-20
On Sat, 2019-09-21 at 21:21 -0400, Dmitry Goncharov wrote:
> On Sat, Sep 21, 2019 at 04:54:59PM -0400, Paul Smith wrote:
> > I pushed a different fix for this issue.  Thanks for noticing!
> Thank you.
> Do you intentionally avoid $! in the "Cannot execute" error message?

No, I just didn't change that code at all so it never came up.  I can
add it.


_______________________________________________
Bug-make mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-make