patch to fix grouped_targets test 1

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

patch to fix grouped_targets test 1

Gnu - Make - Bugs mailing list
Good morning.

echo -n is not portable.
Certain implementations of echo everything, including -n.
This makes test 1 of grouped_targets fail.

regards, Dmitry

diff --git a/tests/scripts/features/grouped_targets
b/tests/scripts/features/grouped_targets
index ef9366b..4d2c9d2 100644
--- a/tests/scripts/features/grouped_targets
+++ b/tests/scripts/features/grouped_targets
@@ -9,9 +9,9 @@ $details = "Here we test for requirements like\n"
 run_make_test(q{
 .PHONY: all
 &:;
-all: ;@echo -n
+all: ;@echo foo
 },
-'', "");
+'', "foo");

 # Parsing: &: works not preceded by whitespace.
 run_make_test(q{

_______________________________________________
Bug-make mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-make
Reply | Threaded
Open this post in threaded view
|

Re: patch to fix grouped_targets test 1

Paul Smith-20
On Tue, 2019-09-10 at 20:36 -0400, Dmitry Goncharov via Bug reports and
discussion for GNU make wrote:
> echo -n is not portable.
> Certain implementations of echo everything, including -n.
> This makes test 1 of grouped_targets fail.

This was already fixed by a patch from Paul Eggert on Aug 27.
Thanks!



commit 8bffc8d53ce302f3170b10c70f3a9680a6b72b68
Author: Paul Eggert <[hidden email]>
Date:   2019-08-27 01:08:47 -0700

    Port grouped_targets test to Solaris 10

    * tests/scripts/features/grouped_targets: Use ‘printf ''’
    instead of ‘echo -n’, as POSIX says the latter is not portable.

diff --git a/tests/scripts/features/grouped_targets b/tests/scripts/features/grouped_targets
index ef9366b..615e962 100644
--- a/tests/scripts/features/grouped_targets
+++ b/tests/scripts/features/grouped_targets
@@ -9,7 +9,7 @@ $details = "Here we test for requirements like\n"
 run_make_test(q{
 .PHONY: all
 &:;
-all: ;@echo -n
+all: ;@printf ''
 },
 '', "");


_______________________________________________
Bug-make mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-make